From b1d0daf47ad7f674d877f2ed3994eaa33b64a18a Mon Sep 17 00:00:00 2001 From: Philipp Fischbeck Date: Thu, 12 Feb 2015 18:26:02 +0100 Subject: [PATCH] Prevent N+1 on title validation --- app/models/translation.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/translation.rb b/app/models/translation.rb index 76e197a..9bd5719 100644 --- a/app/models/translation.rb +++ b/app/models/translation.rb @@ -7,7 +7,7 @@ class Translation < ActiveRecord::Base self.per_page = 50 def title_is_unique_among_other_problems - Problem.where.not(id: problem_id).each do |problem| + Problem.includes(:translation).where.not(id: problem_id).each do |problem| if problem.is_translated? and problem.title == title errors.add(:title, :taken) break